Resolve the OS platform on demand - #1900
Merged
Merged
Conversation
GetOsPlatform throws for any platform outside Linux, Windows, OSX, Android and iOS, and it ran from the Namer static constructor. VerifySettings creates a Namer, so on FreeBSD, browser-wasm or tvOS every verification failed with a TypeInitializationException, including the tests that never asked for UniqueForOSPlatform. It is now resolved by the property, which only PrefixUnique reads, and only when UniqueForOSPlatform is actually set. The message also names the platform now, since 'Unknown OS' gave nothing to act on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetOsPlatform throws for any platform outside Linux, Windows, OSX, Android and iOS, and it ran from the Namer static constructor. VerifySettings creates a Namer, so on FreeBSD, browser-wasm or tvOS every verification failed with a TypeInitializationException, including the tests that never asked for UniqueForOSPlatform.
It is now resolved by the property, which only PrefixUnique reads, and only when UniqueForOSPlatform is actually set. The message also names the platform now, since 'Unknown OS' gave nothing to act on.